Preview for 26.04 release notes — DO NOT MERGE#1256
Conversation
make get-source
| with: | ||
| repository: validmind/installation | ||
| path: site/_source/installation | ||
| ref: nrichers/sc-15270/release-notes-for-26-04 |
There was a problem hiding this comment.
@nrichers reminder to remove this branch ref before merging!
There was a problem hiding this comment.
I pulled your branch into #1253 instead — I called make get-source there as well, so can you approve that one instead (as it has the proper .quartoignore fix)?
(Alternatively, can you explain what adding **/*.quarto_ipynb to the .gitignore accomplishes as you didn't explain in your PR? EDIT: Actually, I noticed that's not what is even added in the .gitignore... hm. Just some commented out R notebooks? I'm extra confused now.)
EDIT: I reverted the changes in my PR to just my preview (will remove the ref to my branch). Trying to make sure these PRs are granular, just fixing the broken links and the .Rmd rendering issue.
validbeck
left a comment
There was a problem hiding this comment.
Sorry, I get it now, I'm easily lost — too many previews for the release notes stuff we had hanging out. I understand that this is for the actual release notes and not the .lua extension now, but may I request you pull in the extension before you publish these?
| with: | ||
| repository: validmind/release-notes | ||
| path: site/_source/release-notes | ||
| ref: nrichers/sc-15270/release-notes-for-26-04 |
There was a problem hiding this comment.
| ref: nrichers/sc-15270/release-notes-for-26-04 |
Co-authored-by: Beck <164545837+validbeck@users.noreply.github.com>
Co-authored-by: Beck <164545837+validbeck@users.noreply.github.com>
Co-authored-by: Beck <164545837+validbeck@users.noreply.github.com>
Co-authored-by: Beck <164545837+validbeck@users.noreply.github.com>
@validbeck I committed your suggestions and pulled in main to get your latest changes. Re-approve this PR, please? |
PR SummaryThis PR updates the GitHub Actions workflow responsible for validating the documentation site by introducing a new parameter Test Suggestions
|
|
@validbeck the penny just dropped. After pulling main into this branch, I realized we don't need this PR other than for the preview. No need to approve. |
make get-sourcemake get-source — DO NOT MERGE
make get-source — DO NOT MERGE
Lighthouse check resultsShow Lighthouse scoresFolder depth level checked: 0 Commit SHA: 825793a Modify the workflow to check a different depth:
|
Validate docs site✓ INFO: A live preview of the docs site is available — Open the preview |
Pull Request Description
What and why?
This PR provides a preview for our 26.04 release notes
and refreshes our library source.Relates to:
How to test
What needs special review?
Dependencies, breaking changes, and deployment notes
Release notes
Checklist