Skip to content

Preview for 26.04 release notes — DO NOT MERGE#1256

Open
nrichers wants to merge 22 commits intomainfrom
nrichers/sc-15270/release-notes-for-26-04
Open

Preview for 26.04 release notes — DO NOT MERGE#1256
nrichers wants to merge 22 commits intomainfrom
nrichers/sc-15270/release-notes-for-26-04

Conversation

@nrichers
Copy link
Copy Markdown
Collaborator

@nrichers nrichers commented Mar 29, 2026

Pull Request Description

What and why?

This PR provides a preview for our 26.04 release notes and refreshes our library source.

Relates to:

How to test

What needs special review?

Dependencies, breaking changes, and deployment notes

Release notes

Checklist

  • What and why
  • Screenshots or videos (Frontend)
  • How to test
  • What needs special review
  • Dependencies, breaking changes, and deployment notes
  • Labels applied
  • PR linked to Shortcut
  • Unit tests added (Backend)
  • Tested locally
  • Documentation updated (if required)
  • Environment variable additions/changes documented (if required)

@nrichers nrichers added the internal Not to be externalized in the release notes label Mar 29, 2026
@nrichers nrichers changed the title Nrichers/sc 15270/release notes for 26 04 Preview for 26.04 release notes and refresh library source Mar 29, 2026
@nrichers nrichers changed the title Preview for 26.04 release notes and refresh library source Preview for 26.04 release notes + make get-source Mar 31, 2026
@nrichers nrichers requested a review from validbeck March 31, 2026 15:21
with:
repository: validmind/installation
path: site/_source/installation
ref: nrichers/sc-15270/release-notes-for-26-04
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nrichers reminder to remove this branch ref before merging!

Copy link
Copy Markdown
Collaborator

@validbeck validbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled your branch into #1253 instead — I called make get-source there as well, so can you approve that one instead (as it has the proper .quartoignore fix)?

(Alternatively, can you explain what adding **/*.quarto_ipynb to the .gitignore accomplishes as you didn't explain in your PR? EDIT: Actually, I noticed that's not what is even added in the .gitignore... hm. Just some commented out R notebooks? I'm extra confused now.)

EDIT: I reverted the changes in my PR to just my preview (will remove the ref to my branch). Trying to make sure these PRs are granular, just fixing the broken links and the .Rmd rendering issue.

@validbeck validbeck self-requested a review March 31, 2026 19:43
Copy link
Copy Markdown
Collaborator

@validbeck validbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I get it now, I'm easily lost — too many previews for the release notes stuff we had hanging out. I understand that this is for the actual release notes and not the .lua extension now, but may I request you pull in the extension before you publish these?

with:
repository: validmind/release-notes
path: site/_source/release-notes
ref: nrichers/sc-15270/release-notes-for-26-04
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ref: nrichers/sc-15270/release-notes-for-26-04

Copy link
Copy Markdown
Collaborator

@validbeck validbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the .Rmd render issue in #1253 (that also has the latest notebooks/files from validmind-library, so you can in theory revert those to main).

nrichers and others added 4 commits April 1, 2026 13:47
Co-authored-by: Beck <164545837+validbeck@users.noreply.github.com>
Co-authored-by: Beck <164545837+validbeck@users.noreply.github.com>
Co-authored-by: Beck <164545837+validbeck@users.noreply.github.com>
Co-authored-by: Beck <164545837+validbeck@users.noreply.github.com>
@nrichers
Copy link
Copy Markdown
Collaborator Author

nrichers commented Apr 1, 2026

Fixed the .Rmd render issue in #1253 (that also has the latest notebooks/files from validmind-library, so you can in theory revert those to main).

@validbeck I committed your suggestions and pulled in main to get your latest changes. Re-approve this PR, please?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

PR Summary

This PR updates the GitHub Actions workflow responsible for validating the documentation site by introducing a new parameter ref in the job configuration. The workflow now checks out the release notes from a specific branch or tag (nrichers/sc-15270/release-notes-for-26-04) when executing the job. The change ensures that the documentation is built using the correct version of the release notes. Additionally, a ZIP archive (notebooks.zip) appears in the diff, though no modifications were performed on it in this commit.

Test Suggestions

  • Manually trigger the workflow to validate that it correctly checks out the release notes from the specified ref.
  • Verify that the documentation site build and deployment use the intended release notes version.
  • Confirm that the addition of the new ref parameter does not break existing workflows or introduce regressions.

@nrichers
Copy link
Copy Markdown
Collaborator Author

nrichers commented Apr 1, 2026

@validbeck the penny just dropped. After pulling main into this branch, I realized we don't need this PR other than for the preview. No need to approve.

@nrichers nrichers added the DO NOT MERGE PR is not ready to be merged label Apr 1, 2026
@nrichers nrichers changed the title Preview for 26.04 release notes + make get-source Preview for 26.04 release notes + make get-source — DO NOT MERGE Apr 1, 2026
@nrichers nrichers changed the title Preview for 26.04 release notes + make get-source — DO NOT MERGE Preview for 26.04 release notes — DO NOT MERGE Apr 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

Lighthouse check results

⚠️ WARN: Average accessibility score is 0.87 (required: >0.9) — Check the workflow run

Show Lighthouse scores

Folder depth level checked: 0

Commit SHA: 825793a

Modify the workflow to check a different depth:

  • 0: Top-level navigation only — /index.html, /guide/guides.html, ...
  • 1: All first-level subdirectories — /guide/.html, /developer/.html, ...
  • 2: All second-level subdirectories — /guide/attestation/*.html, ...
Page Accessibility Performance Best Practices SEO
/developer/validmind-library.html 0.85 0.70 1.00 0.82
/get-started/get-started.html 0.85 0.74 1.00 0.73
/guide/guides.html 0.81 0.69 1.00 0.82
/index.html 0.93 0.71 1.00 0.82
/releases/all-releases.html 0.86 0.72 1.00 0.73
/support/support.html 0.91 0.68 1.00 0.82
/training/training.html 0.85 0.62 0.96 0.73

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

Validate docs site

✓ INFO: A live preview of the docs site is available — Open the preview

@validbeck validbeck self-requested a review April 1, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO NOT MERGE PR is not ready to be merged internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants