This repository was archived by the owner on Apr 14, 2023. It is now read-only.
Merged
Conversation
apupier
force-pushed
the
86-publishAction
branch
from
e803067 to
043385e
Compare
Collaborator
|
This would be super useful, let me test it, and I may enhance somehow to also add publishing to the "open" package repositories. |
Contributor
Author
Which one do you have in mind? i tis already preconfigured for open-vsx.org https://github.com/errata-ai/vale-vscode/pull/87/files#diff-34ee123d396cf5a23e3ab376f01e7489a8c6eb15a49bb7d2660905f92414d9c8R17 |
Pull requests fixes vale-cli#80 Signed-off-by: Aurélien Pupier <apupier@redhat.com>
fixes vale-cli#86 Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier
force-pushed
the
86-publishAction
branch
from
043385e to
548338e
Compare
ChrisChinchilla
approved these changes
Oct 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requires #81
fixes #86
I guess the tokens will also need to be updated on the GitHub settings as environment secret
See the trigger and the beginnign of the build on my own fork used for testing https://github.com/apupier/vale-vscode/runs/7469982621?check_suite_focus=true (failign as I have nto provided the tokens in the environment)