Open
Conversation
Owner
|
What do you need NaN support for? What's the use-case? |
Author
If a json contains mathematical metadata, a value could be NaN (example: standard deviation of a list, with only 1 element, has a NaN std dev). Separately, it brings compatibility with Python's other json library https://docs.python.org/3/library/json.html since it supports NaN values |
Author
|
Any thoughts on the above? |
Owner
|
The changes look good. Can you please add some test cases for this change? I will merge afterwards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.