Conversation
a3d02b4 to
e22c7ac
Compare
Review SummaryOverall: This PR adds an empty Issue: The file is completely empty. An Suggestion: Either populate the file before merging, or defer the PR until content is ready. At minimum, consider a stub like: # Agents
<!-- TODO: Add repo conventions, build/test commands, and notes for AI coding agents --> |
Review SummaryTwo small issues found; no correctness or security problems. Critical: None Notable:
The |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| @@ -22,9 +22,11 @@ jobs: | |||
|
|
|||
| - name: Claude PR Review | |||
| id: claude-pr-review | |||
There was a problem hiding this comment.
continue-on-error: true silently swallows failures of this step — if the API key expires, the action is broken, or the review hits a rate limit, CI will still go green with no indication that reviews stopped running. This makes failures invisible and hard to debug.
Unless there's a specific reason to tolerate failures here, remove this flag so broken review runs are surfaced as a visible CI failure (or at minimum as a workflow annotation).
| id: claude-pr-review |
| uv run poe package # Build wheel + sdist | ||
| uv run poe build-all # test → package → build-docs | ||
| uv run poe bump # Bump version + generate changelog | ||
| uv run pre-commit run --all-files # Run all pre-commit hooks manually |
There was a problem hiding this comment.
uv run poe bump is listed here as a normal command, but the Boundaries section (line 64) flags it as "Ask first". The placement here implies it's routine, which contradicts the intent. Consider moving it out of the general commands table or adding an inline note that it requires approval.
| uv run pre-commit run --all-files # Run all pre-commit hooks manually | |
| uv run poe bump # Bump version + generate changelog (ask first — see Boundaries) |
Review SummaryOverall: Small, well-structured PR. Two issues worth addressing. CriticalNone. Minor
|
Description
Please provide a clear and concise description of the changes introduced by this pull request.
Checklist
Before submitting this PR, please ensure you have completed the following: