Open
Conversation
matthew-gerstman
requested changes
Jan 17, 2020
Collaborator
matthew-gerstman
left a comment
There was a problem hiding this comment.
Hey Revel!
Thanks so much for opening a PR.
Unfortunately, I'd recommend against merging this one.
The bigger button is easier for touchscreen devices (regardless of screen size) so I'd like to keep it the way it is.
Contributor
|
I think the old way (where the button is the same size as the input) looks like 2 input fields. That's always bugged me. In any case, on smaller screen sizes, it reverts back to the old way, so I'm not concerned. Also, the new way isn't a small button, just smaller. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The submit email button looked weird to me so I changed it.
Before
After