feat(tracing): propagate trace context to writeback tasks in build-index and origin#543
Open
hweawer wants to merge 2 commits intofeat/tracing-origin-infrastructurefrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds trace context propagation to writeback tasks in both the build-index and origin components. The changes enable async writeback operations to be linked back to their originating requests for better distributed tracing.
Changes:
- Updated
writeBackfunction in origin blobserver andPutmethod in build-index tagstore to accept and propagate context - Replaced
writeback.NewTaskcalls withwriteback.NewTaskWithContextto capture trace context from request contexts - Updated all logging statements to use
WithTraceContext(ctx)for consistent trace propagation - Updated tests and mocks to accommodate the new context parameters
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| origin/blobserver/server.go | Added context parameter to handleUploadConflict and writeBack methods; updated to use NewTaskWithContext and added trace-aware logging |
| build-index/tagstore/store.go | Added context parameter to Put method; updated to use NewTaskWithContext and added trace-aware logging |
| build-index/tagserver/server.go | Updated duplicatePutTagHandler and putTag to extract and propagate context to store operations with trace-aware logging |
| build-index/tagstore/store_test.go | Updated test calls to Put method to include context.Background() parameter |
| build-index/tagserver/server_test.go | Updated mock expectations for Put to use gomock.Any() for the new context parameter |
| mocks/build-index/tagstore/store.go | Updated mock implementation to match the new Put signature with context parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Anton-Kalpakchiev
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds trace context propagation to writeback tasks in both the build-index and origin components. The changes enable async writeback operations to be linked back to their originating requests for better distributed tracing.