Skip to content

fix(server): use fallback typings for non-major version and pinned commits#2252

Merged
krzema12 merged 13 commits intotypesafegithub:mainfrom
Vampire:issue-467
Mar 13, 2026
Merged

fix(server): use fallback typings for non-major version and pinned commits#2252
krzema12 merged 13 commits intotypesafegithub:mainfrom
Vampire:issue-467

Conversation

@Vampire
Copy link
Collaborator

@Vampire Vampire commented Mar 13, 2026

Fixes #2253

@krzema12 krzema12 linked an issue Mar 13, 2026 that may be closed by this pull request
@krzema12 krzema12 changed the title fix(server): Correctly use fallback typings for non-major version and pinned commits (#467) fix(server): correctly use fallback typings for non-major version and pinned commits Mar 13, 2026
@krzema12 krzema12 changed the title fix(server): correctly use fallback typings for non-major version and pinned commits fix(server): use fallback typings for non-major version and pinned commits Mar 13, 2026
Vampire and others added 7 commits March 13, 2026 11:46
See typesafegithub#2253 (comment)

It's needed because if CI runs from a contributor's fork, they don't have
GitHub App-specific secrets configured. They, however, do have some default
GITHUB_TOKEN.

The downside of this change is that we won't test GitHub App integration
in CI.
Copy link
Member

@krzema12 krzema12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙇

@krzema12 krzema12 merged commit 3863fed into typesafegithub:main Mar 13, 2026
16 checks passed
@Vampire Vampire deleted the issue-467 branch March 13, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Catalog Typing Fallback broken

2 participants