Implement DMA, DRM for Wayland support rendering layer#2
Open
archanaberry wants to merge 1 commit intotunis4:mainfrom
Open
Implement DMA, DRM for Wayland support rendering layer#2archanaberry wants to merge 1 commit intotunis4:mainfrom
archanaberry wants to merge 1 commit intotunis4:mainfrom
Conversation
Author
|
My compiling with additional DRM, DMA |
|
Slop, couldn't even be asked to create a PR description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the contribution — this is an ambitious and important step for Fishix. Introducing DMA and a DRM-like rendering layer is a major milestone toward real graphical support and future Wayland compatibility.
However, before this can be properly reviewed or merged, a few things need to be improved so the changes are easier to understand and maintain for reviewers and future contributors.
Add a proper PR description
Please include the goal of the change, the scope of the affected subsystems, a short design overview of the DMA/DRM architecture, the current status of the implementation, and a clear list of what is not implemented yet. Large kernel changes need this context so reviewers can evaluate the design decisions.
Reduce the scope
This change appears to cover too many areas at once. Consider splitting it into smaller logical PRs, such as DMA, DRM core, KMS/display handling, userspace/UAPI, and documentation. Smaller PRs are much easier to review, test, and debug.
Adjust documentation claims
Some of the documentation currently sounds as though Wayland support is fully complete. At this stage, it would be more accurate to describe it as experimental or work in progress until compositor testing and stability validation are done.
Explain the architecture
Please document the buffer ownership model, DMA memory lifecycle, synchronization strategy, userspace interaction model, and how closely this design intends to follow Linux DRM semantics. Without this, future contributors will have a harder time extending or debugging the system.
Add a test plan
Please include steps reviewers can use to validate the change, such as booting Fishix in QEMU, checking DRM device initialization, verifying DMA buffer allocation, running a basic rendering or framebuffer test, and listing the expected logs or output.
Keep naming and structure consistent
Please keep naming conventions consistent and maintain clear subsystem boundaries. Mixing major documentation updates with core kernel implementation in one large change makes the codebase harder to navigate.
Summary
The direction of this work is excellent and fits Fishix’s long-term evolution into a modern graphical OS platform. The main issue is not the idea itself, but the presentation, scope, and reviewability. Once the documentation, structure, and testing details are improved, this will be much easier to review and integrate. Great work pushing Fishix forward.