Conversation
Author
|
Also, there's currently no support for Windows, so I'll try implementing it tomorrow. |
* Fixed leftover hard-coded srand
ChickChicky
force-pushed
the
threaded-test
branch
from
4b6baf4 to
5f15f8d
Compare
* Fixed threads implementation for Windows * Changed thread architecture (result is now passed through parameters)
Author
* Removed THREAD_ENABLE * Threads are now enabled if N_THREADS is above zero * Removed useless `volatile` qualifier * Moved `render_thread_params` declaration
* Moved thread objects into parms to remove one malloc call * Added a bit of logging (could probably be removed, though)
Author
|
Now, the issue is that it only uses the global arena, and as such, prevents all threading. |
Author
|
#16 Looks way more promising |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added really crude (optional) threading to
render_pixelsas a new functionrender_pixels_threaded.On my machine, with 5000x5000 and 12 threads, I went from 3'08 without threads down to only 45" when enabling them.