Open
Conversation
Author
|
Example: output-scaled.mp4 |
|
Operations on time should be managed at the grammar level, it makes more sense to expose the raw time as Otherwise you will have to edit the source code whenever you want to add another "timeline" so to say |
Author
|
@adam-devel Oh yea, this makes a lot of sense. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that with
t=sin(time)the variation of the art with time is kind of not ideal, because it just oscillates between two states.To mitigate that the most natural solution seems to be to add a second time variable, that will change with
cos, so I addeds=cos(time).With this instead of oscillating between two states, the art continuously rotates through the seamless set of states.
Quite a simple change, that significantly improves the aesthetics IMO :)
EDIT: As suggested by @adam-devel , I made
t=timeand addedcosfunction. This allows to achieve the same result, but is more simple and flexible.