Skip to content

docs: mention missing OverlayProvider requirement#196

Merged
jungpaeng merged 3 commits intotoss:mainfrom
scarf005:patch-1
Oct 12, 2025
Merged

docs: mention missing OverlayProvider requirement#196
jungpaeng merged 3 commits intotoss:mainfrom
scarf005:patch-1

Conversation

@scarf005
Copy link
Copy Markdown
Contributor

@scarf005 scarf005 commented Sep 17, 2025

Description

mentions missing OverlayProvider requirement.

related: #176

Changes

  • mentioned missing OverlayProvider requirement in README.

Motivation and Context

overlay-kit requires OverlayProvider yet it isn't documented in README.md

How Has This Been Tested?

documentation changes only

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have performed a self-review of my own code.
  • My code is commented, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Further Comments

@scarf005 scarf005 requested a review from jungpaeng as a code owner September 17, 2025 01:32
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Sep 17, 2025

⚠️ No Changeset found

Latest commit: 4102a9e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Sep 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
overlay-kit Ready Ready Preview Comment Sep 17, 2025 1:34am

Copy link
Copy Markdown
Member

@jungpaeng jungpaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vercel
Copy link
Copy Markdown

vercel bot commented Oct 12, 2025

@jungpaeng is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.68%. Comparing base (62e2304) to head (4102a9e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #196   +/-   ##
=======================================
  Coverage   93.68%   93.68%           
=======================================
  Files          12       12           
  Lines         364      364           
  Branches       88       88           
=======================================
  Hits          341      341           
  Misses         22       22           
  Partials        1        1           
Components Coverage Δ
overlay-kit 93.68% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jungpaeng jungpaeng merged commit aaa86ec into toss:main Oct 12, 2025
9 of 10 checks passed
@scarf005 scarf005 deleted the patch-1 branch October 12, 2025 23:03
scarf005 added a commit to scarf005/overlay-kit that referenced this pull request Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants