Skip to content

Use chroma style registry#216

Draft
toshimaru wants to merge 1 commit intomainfrom
codex/compare-style-implementation-to-chroma-styles
Draft

Use chroma style registry#216
toshimaru wants to merge 1 commit intomainfrom
codex/compare-style-implementation-to-chroma-styles

Conversation

@toshimaru
Copy link
Owner

@toshimaru toshimaru commented Sep 5, 2025

Summary

  • replace local style definitions with chroma's built-in styles package
  • rely on chroma's embedded XML styles for theme listing

Related PR

Testing

  • go build -o nyan
  • go test ./...

https://chatgpt.com/codex/tasks/task_e_68b8e55bc300832b8fe349c8a8e528a3

Copilot AI review requested due to automatic review settings September 5, 2025 00:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces local style definitions with Chroma's built-in styles package, eliminating custom style implementations in favor of the upstream library's embedded styles.

  • Removes all custom style definition files (11 style files)
  • Updates import to use Chroma's styles package instead of local implementation
  • Removes local style registry and API functionality

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

File Description
styles/*.go Deletes all custom style definitions (abap, dracula, emacs, monokai, etc.)
styles/api.go Removes local style registry and management functions
styles/api_test.go Removes tests for local style API
cmd/root.go Updates import to use chroma's styles package

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@toshimaru
Copy link
Owner Author

Related PR #6

@toshimaru toshimaru marked this pull request as draft September 5, 2025 00:34
@toshimaru toshimaru force-pushed the codex/compare-style-implementation-to-chroma-styles branch from e933801 to 212e35c Compare October 11, 2025 12:28
@toshimaru toshimaru force-pushed the codex/compare-style-implementation-to-chroma-styles branch from 212e35c to 6b3802d Compare January 11, 2026 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants