Added functionality for signed and encrypted cookies#4
Added functionality for signed and encrypted cookies#4yumitsu wants to merge 4 commits intotomichj:masterfrom
Conversation
|
Hello @yumitsu, thanks for the contribution, this is a great start! I'm still reading through the PR and considering the change. I do see one potential issue that probably needs some refinement. Authenticate Configuration options are provided for both encrypted and signed cookies, but Session#get_cookies_class defers to I believe this means that both Authenticate configuration options, I think the solution is for Session (or it's delegate) to avoid calling the |
|
@tomichj Thanks for your review. Yes, I agree with you, this PR need some changes. |
|
@tomichj Please look at new changes. Thanks! |
Good day. I found that Authenticate doesn't support signed and encrypted cookies yet, so I decided to implement it.
I will be glad if you'll accept PR and maybe even bump gem version. Thanks.