Fix building a list of upgrade operations for model classes by using case insensitive field type names#19
Open
vladbelousoff wants to merge 1 commit intotimster:masterfrom
Open
Conversation
…case insensitive field type names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the change, the library generated migration files using
field_typefrom peewee, for example,UUIDFieldandIntegerFieldhave uppercasedfield_typevalues:Using this field will generate the following migration file:
However, when applying migration, the type is searched using the values from
FIELD_TO_PEEWEEthat only contains lowercase values:Thus, we try to get a value using an incorrect key.
I suggest using casting to lowercase when searching and generating values.