Convert global 'this' references to 'global' before transpiling#25
Merged
sgtcoolguy merged 2 commits intotidev:masterfrom Feb 16, 2018
Merged
Convert global 'this' references to 'global' before transpiling#25sgtcoolguy merged 2 commits intotidev:masterfrom
sgtcoolguy merged 2 commits intotidev:masterfrom
Conversation
… references into 'global' references.
ewanharris
approved these changes
Feb 15, 2018
Member
ewanharris
left a comment
There was a problem hiding this comment.
LGTM
Built and ran through KitchenSink-v2 on Android, iOS and Windows, runs as expected. No problems seen and the app functions as expected
Would like to note that it appears that Uncaught TypeError: Cannot read property '_' of undefined never actually occurred on Windows as I had no issues running KS on Windows with 7.1.0 and transpile enabled before this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a very simple babel plugin to convert global
thisreferences toglobalreferences in advance of transpilation (which would otherwise convert them toundefined). There's a unit test added to confirm the fix.Relates to:
globalas a global!)