Fix a subset of existing lint issues#2252
Closed
peytondmurray wants to merge 1 commit intotensorflow:masterfrom
Closed
Fix a subset of existing lint issues#2252peytondmurray wants to merge 1 commit intotensorflow:masterfrom
peytondmurray wants to merge 1 commit intotensorflow:masterfrom
Conversation
smokestacklightnin
approved these changes
Sep 18, 2024
aktech
approved these changes
Oct 2, 2024
Author
|
Not really sure about the |
smokestacklightnin
approved these changes
Oct 4, 2024
Contributor
|
@gharibian Would you mind taking a look at this and review. |
Author
|
@gharibian Is there anything I can do to help get this merged? I'd really like to get this in so that the lint workflow can get unblocked. |
Member
|
Closing as superseded by #4119 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bunch of existing lint issues that were automatically fixed by
ruff --fix, in preparation for merging #2251. I've ignored a bunch of rule violations, but marked them inruff.tomlso that they can be systematically re-enabled and the violations fixed one by one. The vast majority of these changes are:__future__importsformat()with f-strings, which are faster and more expressive