Conversation
Signed-off-by: Tom <tom@temper.systems>
tjpalmer
commented
Mar 6, 2026
| @@ -131,6 +124,19 @@ fun prepareBuild( | |||
| ) | |||
| } | |||
Contributor
Author
There was a problem hiding this comment.
I also looked into making Watcher call prepareBuild, but there's a larger gap for that change. The down side here is if people add other things in the middle of prepareBuild, but I think this is ok for now, anyway.
tjpalmer
commented
Mar 6, 2026
| module.addEnvironmentBindings(lookupFactory(backendId)!!.environmentBindings) | ||
| } | ||
| }, | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
I could make a superficial test of just this function, but testing for temper watch generally is awkward because of how much infrastructure is currently pulled in there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.