test: created a test for modified AHT exploring algorithm#2
Conversation
MWojniewski
changed the title
| BOOST_AUTO_TEST_SUITE_END() | ||
|
|
||
| } No newline at end of file | ||
| // Core Engine |
There was a problem hiding this comment.
ok, This would need to go to: HoughAccumulatorSection.hpp file.
| for (unsigned idx : thisSection.indices()) { | ||
| const auto &m = measurements[idx]; | ||
| float yL = lineFunctor(m, xMin); | ||
| float yR = lineFunctor(m, xMax); |
There was a problem hiding this comment.
The line functor is expected to be called with a single parameter which is x... no?
| const auto &m = measurements[idx]; | ||
| float yL = lineFunctor(m, xMin); | ||
| float yR = lineFunctor(m, xMax); | ||
| float yM = (yL + yR) * 0.5; |
There was a problem hiding this comment.
If we do expand (above) then this is not valid yM anymore. I would suggest to call isLineInside member of HoughAccumulatorSection
There was a problem hiding this comment.
This would also eliminate the need to repeat 3 times the same kind of code.
| { 0.05, 1.0}, // y = 0.05x + 1 | ||
| { 0.08, 1.01}, // y = 0.08x + 1.01 | ||
| {-0.1, 3.0} // y = -0.1x + 3 | ||
| }; |
There was a problem hiding this comment.
Are these the points on lines ? Or line definitions?
Maybe let's generate set of points (e.g. 3) according to the above formulas and feed that into the finder?
There was a problem hiding this comment.
Or I may have not understood the test actually. So we need the description.
2 participants
Modified version of HoughAccumulatorSectionTest.cpp involves test for modified ExploreParametersSection method. Additionally decision functor and PassIntersectionsCheck method were changed.