Skip to content

fix:TAP-10535 When assigning permissions to a role, for connections a… #3092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
weiliang110100 wants to merge 1 commit into
base: develop
Choose a base branch
from
+5 −1
Open

fix:TAP-10535 When assigning permissions to a role, for connections a… #3092

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion manager/tm/src/main/java/com/tapdata/tm/user/service/UserServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,7 +622,11 @@ public void updatePermissionRoleMapping(UpdatePermissionRoleMappingDto dto, User
}
});

biConsumer.accept(dto.getAdds(), (permissions, addRoleMappingDtos, roleId) -> {
biConsumer.accept(dto.getAdds(), (permissions, wholeRoleMappingDtos, roleId) -> {
// 只添加用户指定的权限，不自动添加子权限
List<RoleMappingDto> addRoleMappingDtos = dto.getAdds().stream()
.filter(r -> r.getRoleId().equals(roleId))
Copy link

@augmentcode augmentcode bot Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r.getRoleId().equals(roleId) can throw an NPE if any incoming RoleMappingDto has a null roleId (and it would be grouped under a null roleId as well). Consider making this role-id comparison null-safe to avoid a hard failure on unexpected/invalid input.

Severity: low

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

.collect(Collectors.toList());
if (CollectionUtils.isNotEmpty(addRoleMappingDtos)) {
//去重
List<Criteria> queryExistsCriteriaList = addRoleMappingDtos.stream()
Expand Down
Loading