Skip to content

feat:TAP-9662 Construct a logical view based on MDM through mongo agg…#186

Open
weiliang110100 wants to merge 1 commit intomainfrom
TAP-9662-main
Open

feat:TAP-9662 Construct a logical view based on MDM through mongo agg…#186
weiliang110100 wants to merge 1 commit intomainfrom
TAP-9662-main

Conversation

@weiliang110100
Copy link
Contributor

…regation

@augmentcode
Copy link

augmentcode bot commented Mar 19, 2026

🤖 Augment PR Summary

Summary: Adds a new type attribute to TapTable so schema metadata can label tables (e.g., logical views built from MDM aggregation).

Changes:

  • Introduced `type` field on `TapTable` with corresponding getter/setter

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

return logicPrimaries;
}

private String type;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TapTable is Serializable and the default ObjectSerializable.FromObjectOptions serializes Serializable objects via Java serialization; adding this new field will change the computed serialVersionUID and can break deserialization of previously persisted TapTable instances after an upgrade. Please double-check backward-compatibility expectations for any stored/cached TapTable blobs (e.g., KV/sequence storage, offsets).

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant