Fix RefCell re-entrancy panic during isolate cleanup#572
Open
MarcelKaeding wants to merge 1 commit intomainfrom
Open
Fix RefCell re-entrancy panic during isolate cleanup#572MarcelKaeding wants to merge 1 commit intomainfrom
MarcelKaeding wants to merge 1 commit intomainfrom
Conversation
When a Dart isolate exits, `on_isolate_destroyed` holds a mutable borrow on a RefCell while removing entries. Dropped entries' DropNotifier callbacks attempt to re-borrow the same RefCell, causing a panic: "RefCell<T> already mutably borrowed". Fix by ensuring RefCell borrows are released before values are dropped: - drop_manager.rs: bind removed value so it outlives the temporary borrow - reader_manager.rs: collect keys first, then remove one at a time so each borrow is scoped to a single remove() call Fixes #571 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
I'd need to reproduce this first, but bigger issue here is that super_native_extensions and irondash first need to be migrated to native assets before doing another release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RefCell<T> already mutably borrowed) on Android when a Dart isolate exitson_isolate_destroyed, a mutableRefCellborrow is held whileretain()drops removed entries — theirDropNotifierdestructors attempt to re-borrow the sameRefCell, causing a panicRefCellborrow is released before the value's destructors runremove()callTest plan
cargo checkpasses with no warningsFixes #571
🤖 Generated with Claude Code