Skip to content

fix(super_hot_key): use KeyboardKey instead of PhysicalKeyboardKey#561

Open
MSOB7YY wants to merge 4 commits intosuperlistapp:mainfrom
MSOB7YY:main
Open

fix(super_hot_key): use KeyboardKey instead of PhysicalKeyboardKey#561
MSOB7YY wants to merge 4 commits intosuperlistapp:mainfrom
MSOB7YY:main

Conversation

@MSOB7YY
Copy link

@MSOB7YY MSOB7YY commented Nov 28, 2025

for some reason, the HotKeyDefinition uses PhysicalKeyboardKey instead of KeyboardKey (

final PhysicalKeyboardKey key;
)

even tho the internal implementation supports KeyboardKey:

int? getPlatformKeyCode(KeyboardKey key) {
if (key is PhysicalKeyboardKey) {
return _physicalToKey[key.usbHidUsage]?.platform;
} else if (key is LogicalKeyboardKey) {
return _logicalToKey[key.keyId]?.platform;
} else {
return null;
}
}

not sure why it wasn't like that, most likely a typo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant