Skip to content

feat: add .editorconfig and .gitattributes for consistent file formatting#328

Open
ChuckieChen945 wants to merge 1 commit intosuperlinear-ai:mainfrom
ChuckieChen945:feature
Open

feat: add .editorconfig and .gitattributes for consistent file formatting#328
ChuckieChen945 wants to merge 1 commit intosuperlinear-ai:mainfrom
ChuckieChen945:feature

Conversation

@ChuckieChen945
Copy link

close #327

@davebulaval
Copy link

Thanks for the contribution @ChuckieChen945! 🙏

We identified a few issues with this PR:

  1. Wrong directory: Files are placed in template/ but our cookiecutter template directory is {{ cookiecutter.__project_name_kebab_case }}/
  2. .editorconfig already exists: The template already has one — this would create a duplicate in the wrong location
  3. max_line_length: Set to 88 but our Baseline convention uses 99

We've incorporated the good parts of your contribution (especially .gitattributes) with the necessary fixes in #28.

Thanks again for the idea — the .gitattributes addition is a great improvement!

@ChuckieChen945
Copy link
Author

We've incorporated the good parts of your contribution (especially .gitattributes) with the necessary fixes in #28.

In addition, this PR has been absorbed by Baseline-quebec/baseline-app-cookiecutter here:
Baseline-quebec#28 , not #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature request]Add .editorconfig and .gitattributes for workspace consistency

2 participants