Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the recommended Python versions for the substrate project template, upgrading from Python 3.10/3.12 to Python 3.12/3.13. Apps are now recommended to use Python 3.13, while packages should use Python 3.12 as their minimum version. The PR also fixes a bug where GitHub Actions tests were using a hardcoded Python version instead of testing across the matrix of versions.
Key changes:
- Updated default Python version recommendations: 3.13 for apps, 3.12 for packages
- Fixed GitHub Actions to use matrix Python version instead of hardcoded value
- Upgraded project's own Python requirement to 3.13
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
uv.lock |
Regenerated lockfile for Python 3.13, removing Python 3.10-3.12 specific wheels |
test.sh |
Updated hardcoded Python version from 3.10 to 3.12 for test scaffolding |
pyproject.toml |
Changed requires-python from ">=3.10" to ">=3.13,<3.14" |
copier.yml |
Updated template defaults: apps use 3.13, packages use 3.12 (previously 3.12 and 3.10) |
.github/workflows/test.yml |
Fixed to use matrix.python-version instead of hardcoded "3.10" for proper multi-version testing |
.devcontainer/devcontainer.json |
Updated base image from python3.10-trixie to python3.13-trixie |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: