Add GitHub pull request integration to the mac app#22
Closed
Conversation
70001a2 to
9ae4469
Compare
Contributor
Author
|
Closing all open PRs per request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gh-backed GitHub integration with explicit availability and auth states, repo-level batched PR refresh, upstream-first multi-remote resolution, richer PR and check models, and sidebar presentation plus open-PR action.Rationale
The implementation keeps branch watching close to each workspace but moves PR refresh to the repository level so multiple workspaces in the same repo share one GitHub lookup path. It also preserves fork correctness by preferring
upstream, thenorigin, then other GitHub remotes, and carrying host, owner, and repo data through the lookup path so GitHub Enterprise hosts work the same way.User-visible / Behavior Changes
Diagram (if applicable)
Human Verification
SettingsFeatureTestsandGithubPullRequestParsingTests,make mac-lint, and the full pre-push path:make web-check,make web-test, andmake mac-test.gh, GitHub CLI command failure handling, upstream-vs-fork PR selection, and settings reducer task ordering.