Merged
Conversation
Summary: - remove hook-driven Codex running transitions from the canonical hook set and app-side registry - start Codex transcript tracking from SessionStart and UserPromptSubmit, including active resume snapshots - rewrite Codex regression coverage and integration docs around the transcript-driven lifecycle Rationale: - Codex activity was split across hook side effects for running state and transcript parsing for detail/final states - reading the transcript snapshot before polling removes the startup blind spot where an already-running turn was missed on resume Tests: - make -C apps/mac lint - xcodebuild test -workspace apps/mac/supaterm.xcworkspace -scheme supaterm -destination "platform=macOS" -only-testing:supatermTests/SupatermCodexHookSettingsTests -only-testing:supatermTests/CodexSettingsInstallerTests -only-testing:supatermTests/CodexTranscriptMonitorTests -only-testing:supatermTests/TerminalAgentSessionStoreTests -only-testing:supatermTests/TerminalWindowRegistryTests CODE_SIGNING_ALLOWED=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY="" -skipMacroValidation
fe704bc to
1ddba25
Compare
Summary: - track Codex hover-message history separately from the running tab detail - feed hover history from transcript assistant messages and stop payloads - show the hover markdown in the sidebar popover while keeping row detail compact and truncated Rationale: - the popover has room for richer transcript context than the tab row - final answers should replace transient hover history without reusing the running subtitle path - keeping full hover text avoids cutting off long assistant messages in the expanded popover Tests: - make -C apps/mac lint - xcodebuild test -workspace apps/mac/supaterm.xcworkspace -scheme supaterm -destination "platform=macOS" -only-testing:supatermTests/CodexTranscriptMonitorTests -only-testing:supatermTests/TerminalHostStateNotificationTests -only-testing:supatermTests/TerminalSidebarChromeViewTests -only-testing:supatermTests/TerminalWindowRegistryTests CODE_SIGNING_ALLOWED=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY="" -skipMacroValidation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.runningfrom managed tool hooks instead of the transcript lifecycle.SessionStart,UserPromptSubmit, andStop, and the follow-up simplify pass removed duplicated turn-prep and activity-handling branches.Stop, running subtitle priority still comes from transcript content, and other agent integrations were not changed.Rationale
The transcript is the only source that actually describes turn start, turn progress, and turn completion. Driving status from hook side effects left a blind spot on resume and kept Codex activity coupled to events that are not authoritative. This change moves status to the same source of truth that already drives running detail, while keeping hook handling limited to session setup and structured completion.
User-visible / Behavior Changes
.runningwhen transcript lifecycle events report a started turn, including startup and resume from an already-active transcript..idleon transcript completion and abort events, withStopstill acting as the structured completion fallback.UserPromptSubmitno longer marks Codex running by itself.Diagram (if applicable)
Human Verification
UserPromptSubmitwithout forcing running, transcript abort/completion paths, and the simplification pass preserving the same registry/session-store behavior.Stopstill delivers completion notifications.