Skip to content

SUP-47: Add GitHub PR surfaces to sidebar and pane topbar#15

Closed
khoi wants to merge 1 commit intomainfrom
khoiracle/sup-47-add-github-pr-surfaces-to-sidebar-and-pane-topbar
Closed

SUP-47: Add GitHub PR surfaces to sidebar and pane topbar#15
khoi wants to merge 1 commit intomainfrom
khoiracle/sup-47-add-github-pr-surfaces-to-sidebar-and-pane-topbar

Conversation

@khoi
Copy link
Copy Markdown
Contributor

@khoi khoi commented Apr 9, 2026

Summary

  • add a shared GitHub client/coordinator pipeline that discovers git/gh, resolves remotes, looks up PRs, and stores PR snapshots per terminal surface
  • add GitHub settings and diagnostics, then render shared PR presentation in the sidebar row and selected pane topbar
  • add focused tests for settings persistence, PR lookup behavior, coordinator cadence/coalescing, and sidebar presentation

Testing

  • make -C apps/mac lint
  • xcodebuild test -workspace apps/mac/supaterm.xcworkspace -scheme supaterm -destination "platform=macOS" -parallel-testing-enabled NO -only-testing:supatermTests/SettingsFeatureTests -only-testing:supatermTests/SupatermSettingsTests -only-testing:supatermTests/SupatermSettingsSchemaTests -only-testing:supatermTests/TerminalSidebarChromeViewTests -only-testing:supatermTests/GithubClientTests -only-testing:supatermTests/GithubPullRequestRefreshCoordinatorTests CODE_SIGNING_ALLOWED=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY="" -skipMacroValidation
  • push hook validation passed, including web checks and the full mac test suite

@khoi
Copy link
Copy Markdown
Contributor Author

khoi commented Apr 11, 2026

Closing all open PRs per request.

@khoi khoi closed this Apr 11, 2026
@khoi khoi deleted the khoiracle/sup-47-add-github-pr-surfaces-to-sidebar-and-pane-topbar branch April 11, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant