fix: exclude aggregates and window functions from search path lint#148
Open
oniani1 wants to merge 1 commit intosupabase:mainfrom
Open
fix: exclude aggregates and window functions from search path lint#148oniani1 wants to merge 1 commit intosupabase:mainfrom
oniani1 wants to merge 1 commit intosupabase:mainfrom
Conversation
The function_search_path_mutable lint flags aggregates and window functions even though PostgreSQL rejects setting search_path on them. Filter these out via prokind. Fixes supabase#139
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #139
The
function_search_path_mutablelint queriespg_procwithout filtering onprokind, so it flags aggregate and window functions. These can't havesearch_pathconfigured -- PostgreSQL rejects it:This adds
p.prokind not in ('a', 'w')to exclude aggregates and window functions from the lint.Changes:
lints/0011_function_search_path_mutable.sql-- filter onprokindsplinter.sql-- sametest/sql/0011_function_search_path_mutable.sql-- test case creating an aggregate, verifying it's not flaggedtest/expected/0011_function_search_path_mutable.out-- expected output