Skip to content

[gateway] add replace for https to support wildcard host #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arnelasse wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[gateway] add replace for https to support wildcard host #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c81118
add replace for https to support wildcard host.
Jan 19, 2026
64051f3
Merge branch 'main' into allow-wildcard-host
arnelasse Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/gateway/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.0.6
version: 1.1.0
annotations:
artifacthub.io/changes: |
- kind: fixed
Copy link
Copy Markdown
Member

@DanielRaapDev DanielRaapDev Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

die Changes bitte aktualisieren

Expand Down
2 changes: 1 addition & 1 deletion charts/gateway/templates/gateway.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ spec:
{{- toYaml . | nindent 4 }}
{{- end }}
{{- range .Values.gateway.https }}
- name: "https-{{ .host }}"
- name: "https-{{ .host | replace "*" "wildcard" | replace "_" "" }}"
Copy link
Copy Markdown
Member

@DanielRaapDev DanielRaapDev Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sollten auch andere Sonderzeichen ersetzt werden?

Muss die Ersetzung hier im Chart passieren oder wäre es besser wenn bei der Verwendung ein eigener Name angegeben werden kann? gateway.https.nameOverride oder so? Das sieht mir schon sehr spezifisch aus. Liegt das sogar an der Implementation des Gateways welche Namen dort erlaubt sind? Aus YAML Sicht ist das einfach nur ein String 🤔

Copy link
Copy Markdown
Member

@DanielRaapDev DanielRaapDev Jan 20, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah OK, die Spec schreibt hier vor, dass nur so etwas wie DNS-Namen verwendet werden dürfen:

MaxLength: 253
MinLength: 1
Pattern: ^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$

Dann sollte das Replace alles für [^-a-z0-9.] ersetzen durch z.B. -.

hostname: "{{ .host }}"
port: 443
protocol: HTTPS
Expand Down