Unit test for the no slip boundary conditions and assigning correct parameters to ghost particles in sph_mean_coeffs#181
Open
aminrai2000 wants to merge 74 commits intodevelfrom
Open
Unit test for the no slip boundary conditions and assigning correct parameters to ghost particles in sph_mean_coeffs#181aminrai2000 wants to merge 74 commits intodevelfrom
aminrai2000 wants to merge 74 commits intodevelfrom
Conversation
This class will replace main.run and main.pproc. Conceptually, a StruphyModel represents the physics model, including its variables and equation parameters. A simulation takes StruphyModel as input and additionally deals with geometry, initial conditions, allocation of memory, and the actual solution process. I started moving some methos/functions into the new Simulation class.
…class; it now orks for fields; restart logic becomes simpler too.
…ing a StruphySimulation OR a path
…model() should be called when species properties are changed.
… particles; this happens by default at first_free_idx for noslip boundary conditions. Unit test still needs to be adapted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves the following issue(s):
unit testing the no slip bc and correcting the ghost particles behaviour