Merged
Conversation
would get js warning re un-/maximize wanting 0 args but got 1. Unsure if it would have been better or worse to ditch the args instead of going with `set-[un-]maximize-flags`.
installation steps
There was a problem hiding this comment.
Pull request overview
This PR adapts the Window Gestures GNOME Shell extension for GNOME 49 API changes and updates the README with manual installation instructions (including guidance for GNOME 49 where extensions.gnome.org isn’t available).
Changes:
- Updated GNOME Shell/Mutter API usage in
src/extension.js(rectangle type and window maximize/unmaximize/maximized checks). - Updated
README.mdto reflect GNOME 49 support and add manual installation steps.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/extension.js | Updates Mutter/GNOME Shell API calls related to preview rectangles and maximize/unmaximize/maximized detection. |
| README.md | Updates support statement and adds a manual installation section (with the old GNOME Extensions badge commented out). |
Comments suppressed due to low confidence (1)
src/extension.js:2510
winIsMaximizedis assigned fromactiveWin.is_maximized()but then compared againstMeta.MaximizeFlags.BOTHand later overwritten withMeta.MaximizeFlags.VERTICAL. This mixes boolean/flag semantics and makeswinMaxedincorrect (it will never be true ifis_maximized()returns a boolean), which will break the maximize/fullscreen/restore action selection. Consider using a maximize-flags getter (if available) for flag comparisons, or compute separate booleans for “any maximized” vs “fully maximized” without reusing the same variable for both types.
let winCanMax = activeWin.allows_move() && activeWin.can_maximize();
let winIsMaximized = activeWin.is_maximized();
let winMaxed = Meta.MaximizeFlags.BOTH == winIsMaximized;
if (activeWin.isTiled) {
winIsMaximized = Meta.MaximizeFlags.VERTICAL;
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+4
to
+8
| Support up to gnome 49. | ||
|
|
||
| ## Installation | ||
| [](https://extensions.gnome.org/extension/6343/window-gestures/) | ||
| *Gnome extension repository don't support Gnome 49* | ||
| ### Manually |
| ## Installation | ||
| [](https://extensions.gnome.org/extension/6343/window-gestures/) | ||
| *Gnome extension repository don't support Gnome 49* | ||
| ### Manually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.