fix: fallback to references when object not found by id#56
Open
SilverRainZ wants to merge 1 commit intomasterfrom
Open
fix: fallback to references when object not found by id#56SilverRainZ wants to merge 1 commit intomasterfrom
SilverRainZ wants to merge 1 commit intomasterfrom
Conversation
When resolving a PendingObject, if the object is not found by (objtype, objid), fallback to searching references to find the object. Co-authored-by: MiniMax-M2.1 <minimax-cn-coding-plan@users.noreply.github.com> Co-authored-by: opencode <opencode@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When resolving a
PendingObject, if the object is not found by(objtype, objid)inobjects, fallback to searchingreferencesto find the object.Changes
Modified
PendingObject.resolve()indomain.pyto:(objtype, objid)inobjectsreferencesusing(objtype, _, objid)patternobjidto retrieve the objectAdded unit tests in
tests/test_domain.pycovering:Co-authored-by: MiniMax-M2.1 minimax-cn-coding-plan@users.noreply.github.com
Co-authored-by: opencode opencode@users.noreply.github.com