fix(web): use Link for Go to Definition to allow opening in new tab (#793)#799
Open
jruttan1 wants to merge 2 commits intosourcebot-dev:mainfrom
Open
fix(web): use Link for Go to Definition to allow opening in new tab (#793)#799jruttan1 wants to merge 2 commits intosourcebot-dev:mainfrom
jruttan1 wants to merge 2 commits intosourcebot-dev:mainfrom
Conversation
Contributor
WalkthroughThe PR modifies the symbol hover popup component to render a Link to a definition when a single, in-file definition exists. It computes the definition href using domain context and path information, falling back to the LoadingButton behavior for multiple definitions or when no definitive href is available. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: This PR updates the "Go to Definition" button in the symbol hover tooltip to use a Nextjs Link component when a definition is found
Changes:
Uses getBrowsePath to correctly generate the destination URL
Conditionally renders a for single definitions, allowing users to Cmd Click / Middle Click to open the file in a new tab
Notes:
I chose not to update the "Find References" button in this PR. Since that action primarily toggles the side panel state rather than navigating to a distinct resource, it feels more appropriate to keep it as a button for now to ensure stable behaviour.
Fixes #793
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.