-
Notifications
You must be signed in to change notification settings - Fork 4
feat: 모의지원 페이지 UI를 멘토 디자인 톤으로 공통화 #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import BlockBtn from "@/components/button/BlockBtn"; | ||
|
|
||
| type ApplicationBottomActionBarProps = { | ||
| label: string; | ||
| onClick: () => void; | ||
| }; | ||
|
|
||
| const ApplicationBottomActionBar = ({ label, onClick }: ApplicationBottomActionBarProps) => { | ||
| return ( | ||
| <div className="fixed bottom-14 w-full max-w-app bg-white"> | ||
| <div className="mb-[37px] px-5"> | ||
| <BlockBtn onClick={onClick}>{label}</BlockBtn> | ||
| </div> | ||
| </div> | ||
| ); | ||
| }; | ||
|
Comment on lines
+8
to
+16
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Search for fixed bottom positioning patterns
echo "=== Searching for 'fixed bottom' patterns ==="
rg "fixed bottom" --type=tsx -C 3
echo -e "\n=== Searching for max-w-app usage with fixed positioning ==="
rg "fixed.*max-w-app|max-w-app.*fixed" --type=tsx -C 2
echo -e "\n=== Checking app container structure ==="
rg "max-w-app" --type=tsx -C 1 | head -50Repository: solid-connection/solid-connect-web Length of output: 328 🏁 Script executed: #!/bin/bash
# Search for fixed bottom positioning patterns in tsx files
echo "=== Searching for 'fixed bottom' in tsx files ==="
rg "fixed.*bottom" -g '*.tsx' -C 3
echo -e "\n=== Searching for ApplicationBottomActionBar usage ==="
rg "ApplicationBottomActionBar" -g '*.tsx' -C 2
echo -e "\n=== Checking the app layout structure for centering ==="
rg "max-w-app" -g '*.tsx' -C 2 | head -80
echo -e "\n=== Looking for fixed elements with centering utilities ==="
rg "fixed.*(left-|translate-)" -g '*.tsx' -C 2Repository: solid-connection/solid-connect-web Length of output: 28109 고정 위치 지정 요소에 가로 중앙 정렬이 누락되었습니다.
🤖 Prompt for AI Agents |
||
|
|
||
| export default ApplicationBottomActionBar; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| type ApplicationSectionTitleProps = { | ||
| title: string; | ||
| description?: string; | ||
| className?: string; | ||
| }; | ||
|
|
||
| const ApplicationSectionTitle = ({ title, description, className = "" }: ApplicationSectionTitleProps) => { | ||
| return ( | ||
| <div className={className}> | ||
| <h2 className="text-k-900 typo-bold-5">{title}</h2> | ||
| {description ? <p className="mt-1 text-k-500 typo-regular-2">{description}</p> : null} | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default ApplicationSectionTitle; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: solid-connection/solid-connect-web
Length of output: 1579
🏁 Script executed:
Repository: solid-connection/solid-connect-web
Length of output: 7060
🏁 Script executed:
Repository: solid-connection/solid-connect-web
Length of output: 1404
🏁 Script executed:
Repository: solid-connection/solid-connect-web
Length of output: 1048
🏁 Script executed:
Repository: solid-connection/solid-connect-web
Length of output: 1095
nicknameForApply를 React의 key로 사용할 때는 유일성이 보장되어야 합니다.현재 코드에서 문제점:
타입 정의 확인
nicknameForApply는Applicant인터페이스에서 단순string타입으로만 정의되어 있으며, 유일성 보장이 없습니다.잠재적 위험
동일한
ScoreSheet내에서 두 지원자가 같은 닉네임을 사용할 경우, React의 재조정이 제대로 작동하지 않아 UI 업데이트 오류가 발생할 수 있습니다.권장 개선안
id,applicantId)가 있다면 그것을 key로 사용하세요.nicknameForApply의 유일성이 보장된다면, 타입 정의에 명시적으로 표기하는 것이 좋습니다.🤖 Prompt for AI Agents