Add Py3k warning for list comprehension target rebinding and regression test#45
Open
Eddy114514 wants to merge 3 commits intosoftdevteam:migrationfrom
Open
Add Py3k warning for list comprehension target rebinding and regression test#45Eddy114514 wants to merge 3 commits intosoftdevteam:migrationfrom
Eddy114514 wants to merge 3 commits intosoftdevteam:migrationfrom
Conversation
ltratt
reviewed
Feb 26, 2026
| return 1; | ||
| } | ||
|
|
||
| static int |
Member
There was a problem hiding this comment.
AFAICS the return int is either 0 or 1 so a bool in disguise? I'm not sure what true/false mean here though: there was/wasn't an error?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List comprehensions that rebind an outer name (e.g. x in [x = ...; [x for x in ...]] can cause 2.x vs 3.x behavior differences. Specifically, in python 2, it will rebind the outer variable, but in 3.x, it will not.
I added a symbol-table check in
symtable.cto detect listcomp target rebinding and emit the warning. I add test intest_grammer.pyand it passed on my local machine.