Skip to content

fix(services): HealthChecker.Register immediately populates cache when already running #1976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmank88 merged 2 commits into from
Apr 13, 2026
+14 −1
Merged

fix(services): HealthChecker.Register immediately populates cache when already running #1976

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
575541a
fix(services): populate health state directly in Register
Fletch153 Apr 13, 2026
faff2bf
fix(services): restore Unregister unlock and revert cosmetic changes
Fletch153 Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion pkg/services/health.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,13 +219,26 @@ func (c *HealthChecker) Register(service HealthReporter) error {
}

c.servicesMu.Lock()
defer c.servicesMu.Unlock()
if testing.Testing() {
if orig, ok := c.services[name]; ok {
panic(fmt.Errorf("duplicate name %q: service names must be unique: types %T & %T", name, service, orig))
}
}
c.services[name] = service
c.servicesMu.Unlock()

// Populate health state directly for the new service so it is
// visible immediately without waiting for the next polling tick.
ready := service.Ready()
report := service.HealthReport()

c.stateMu.Lock()
c.ready[name] = ready
for n, err := range report {
c.healthy[n] = err
}
c.stateMu.Unlock()

return nil
}

Expand Down
Loading