Skip to content

[DX-3716] Use FORCE to drop DBs#1973

Open
kalverra wants to merge 4 commits intomainfrom
sqltest-drop-with-force
Open

[DX-3716] Use FORCE to drop DBs#1973
kalverra wants to merge 4 commits intomainfrom
sqltest-drop-with-force

Conversation

@kalverra
Copy link
Copy Markdown
Contributor

@kalverra kalverra commented Apr 9, 2026 •
edited
Loading

Prevent tests from locking up on old connections.

In conjunction with smartcontractkit/chainlink#21947

@kalverra kalverra requested a review from a team as a code owner April 9, 2026 20:56
Copilot AI review requested due to automatic review settings April 9, 2026 20:56
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

👋 kalverra, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026 •
edited
Loading

📊 API Diff Results

No changes detected for module github.com/smartcontractkit/chainlink-common

View full report

Copilot AI reviewed Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Postgres test DB lifecycle utilities to more reliably drop databases that still have open connections, preventing tests from hanging.

Changes:

  • Use quoted identifiers for database/template names when issuing DROP DATABASE / CREATE DATABASE.
  • Switch database dropping to DROP DATABASE ... WITH (FORCE) to terminate remaining backends.
  • Increase cleanup retry sleep interval during best-effort drop on test cleanup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mchain0
mchain0 previously approved these changes Apr 13, 2026
View reviewed changes
@kalverra kalverra enabled auto-merge April 13, 2026 13:07
jmank88
jmank88 reviewed Apr 13, 2026
View reviewed changes
@kalverra kalverra requested a review from Copilot April 13, 2026 13:47
Copilot AI reviewed Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kalverra kalverra requested review from jmank88 and mchain0 April 13, 2026 14:55
@jmank88 jmank88 requested a review from pavel-raykov April 13, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@jmank88 jmank88 jmank88 approved these changes

@agparadiso agparadiso Awaiting requested review from agparadiso

@mchain0 mchain0 Awaiting requested review from mchain0

@pavel-raykov pavel-raykov Awaiting requested review from pavel-raykov

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kalverra @jmank88 @mchain0