[MNT] Remove <3.13 bound from mapie in all_extras#883
Open
Mushfiqur719 wants to merge 2 commits intosktime:mainfrom
Open
[MNT] Remove <3.13 bound from mapie in all_extras#883Mushfiqur719 wants to merge 2 commits intosktime:mainfrom
Mushfiqur719 wants to merge 2 commits intosktime:mainfrom
Conversation
e3eecc3 to
02ae674
Compare
fkiraly
requested changes
Mar 13, 2026
Collaborator
fkiraly
left a comment
There was a problem hiding this comment.
This PR includes merge conflicts in the documentation and breaks it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Partially resolves #478.
What does this implement/fix? Explain your changes.
This PR removes the
python_version < "3.13"bound from the MAPIE optional dependency in theall_extrassection ofpyproject.toml.Previously, MAPIE was restricted to Python versions below 3.13:
"mapie; python_version < '3.13'"
This PR updates the dependency specification to:
"mapie"
The goal is to gradually remove
<3.13bounds from optional dependencies as Python 3.13 and NumPy 2 become supported across the ecosystem, as discussed in #478.Verification
The change was tested locally using a Python 3.13 environment.
Does your contribution introduce a new dependency? If yes, which one?
No.
This PR only removes the Python version bound from an existing soft dependency.
What should a reviewer concentrate their feedback on?
pyproject.tomlDid you add any tests for the change?
No new tests were added.
Existing MAPIE-related tests in the repository were executed to confirm compatibility with Python 3.13.
Any other comments?
This PR follows the incremental approach suggested in #478 by unlocking dependencies one at a time.
Further dependencies (e.g.,
lifelines,ngboost,pymc) can be addressed in separate PRs after verification.PR checklist
For all contributions
For new estimators