Skip to content

[MNT] Remove <3.13 bound from mapie in all_extras#883

Open
Mushfiqur719 wants to merge 2 commits intosktime:mainfrom
Mushfiqur719:mnt-mapie-313
Open

[MNT] Remove <3.13 bound from mapie in all_extras#883
Mushfiqur719 wants to merge 2 commits intosktime:mainfrom
Mushfiqur719:mnt-mapie-313

Conversation

@Mushfiqur719
Copy link
Contributor

Reference Issues/PRs

Partially resolves #478.

What does this implement/fix? Explain your changes.

This PR removes the python_version < "3.13" bound from the MAPIE optional dependency in the all_extras section of pyproject.toml.

Previously, MAPIE was restricted to Python versions below 3.13:

"mapie; python_version < '3.13'"

This PR updates the dependency specification to:

"mapie"

The goal is to gradually remove <3.13 bounds from optional dependencies as Python 3.13 and NumPy 2 become supported across the ecosystem, as discussed in #478.

Verification

The change was tested locally using a Python 3.13 environment.

Does your contribution introduce a new dependency? If yes, which one?

No.

This PR only removes the Python version bound from an existing soft dependency.

What should a reviewer concentrate their feedback on?

  • correctness of the dependency change in pyproject.toml
  • confirmation that removing the Python 3.13 bound for MAPIE is safe

Did you add any tests for the change?

No new tests were added.

Existing MAPIE-related tests in the repository were executed to confirm compatibility with Python 3.13.

Any other comments?

This PR follows the incremental approach suggested in #478 by unlocking dependencies one at a time.
Further dependencies (e.g., lifelines, ngboost, pymc) can be addressed in separate PRs after verification.

PR checklist

For all contributions
  • I've added myself to the list of contributors
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG].
For new estimators
  • I've added the estimator to the API reference
  • I've added illustrative examples to the docstring
  • I've set soft dependency tags where required

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR includes merge conflicts in the documentation and breaks it.

@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Continuous integration, unit testing & package distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MNT] gradually remove <3.13 bounds from soft dependencies in all_extras

2 participants