Fix incorrect tag resolution in _get_class_flags with diamond inheritance#511
Open
WHOIM1205 wants to merge 1 commit intosktime:mainfrom
Open
Fix incorrect tag resolution in _get_class_flags with diamond inheritance#511WHOIM1205 wants to merge 1 commit intosktime:mainfrom
WHOIM1205 wants to merge 1 commit intosktime:mainfrom
Conversation
fkiraly
requested changes
Mar 5, 2026
Contributor
fkiraly
left a comment
There was a problem hiding this comment.
Good catch. I assume an AI caught this.
Can you please make sure to:
- remove the AI generated comment and leave the old comment there
- fix the issue title
…ce tag corruption Signed-off-by: WHOIM1205 <rathourprateek8@gmail.com>
cfce7a1 to
e568cc7
Compare
Contributor
Author
thanks for the feedback |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #511 +/- ##
==========================================
- Coverage 85.07% 83.48% -1.60%
==========================================
Files 45 52 +7
Lines 3015 3905 +890
==========================================
+ Hits 2565 3260 +695
- Misses 450 645 +195 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@fkiraly is there anything i can change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix incorrect tag/config resolution in diamond inheritance
Summary
_FlagManager._get_class_flagscurrently useshasattrandgetattrwhen iterating over the class MRO.Because
getattrfollows Python's full attribute lookup chain, classes that do not define_tags(or_config) themselves may still return values inherited from ancestors.In diamond inheritance scenarios this can re-apply ancestor flags later in the merge order and overwrite overrides coming from mixins.
Example