fix: --continue uses last logged conversation id#1377
Open
BillionClaw wants to merge 1 commit intosimonw:mainfrom
Open
fix: --continue uses last logged conversation id#1377BillionClaw wants to merge 1 commit intosimonw:mainfrom
BillionClaw wants to merge 1 commit intosimonw:mainfrom
Conversation
When using --continue without specifying a conversation ID, the code was ordering conversations by 'id desc' which doesn't reflect the chronological order of activity. This caused --continue to potentially select the wrong conversation. Now it queries responses ordered by datetime_utc to find the conversation with the most recent activity. Fixes simonw#1140
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1140.
When using
--continuewithout specifying a conversation ID, the code was ordering conversations byid descwhich doesn't reflect the chronological order of activity. Conversation IDs are user-defined strings (like "foo", "bar") and not timestamps.This fix queries the responses table ordered by
datetime_utcto find the conversation with the most recent activity, which is the expected behavior for continuing the last conversation.The change:
responsesinstead ofconversationsdatetime_utc descinstead ofid descconversation_idfrom the most recent response