[WIP] fix for writing of virtuals in Desmond#304
Open
mrshirts wants to merge 7 commits intoshirtsgroup:masterfrom
Open
[WIP] fix for writing of virtuals in Desmond#304mrshirts wants to merge 7 commits intoshirtsgroup:masterfrom
mrshirts wants to merge 7 commits intoshirtsgroup:masterfrom
Conversation
Contributor
Author
|
Don't commit yet - this is just so people can see it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See comments in individual commits. A WIP for solution to issue #297. Mostly working, 1) but the energies are not quite right for several virtual tests, 2) TIP4P crashes, I think because of exclusions issues, and 3) exceptions need to be added for virtual geometries that don't work (or in some cases, canonicalizing functions need to be called).