feat(ui-react): add admin firewall rules list and detail pages#6116
Open
feat(ui-react): add admin firewall rules list and detail pages#6116
Conversation
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
luizhf42
added
kind/feature
Read-only admin pages for instance-wide firewall rule visibility. List page with 7-column table, client-side search, and pagination. Detail page with rule properties and connection criteria cards. Also fixes filter normalization in useFirewallRules to correctly handle API responses where both hostname and tags fields are present, and swaps FilterBadge hostname icon to CpuChipIcon for clarity.
luizhf42
force-pushed
the
feat/ui-react/admin-firewall-rules-pages
branch
from
75c77e0 to
83a69c3
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Read-only admin pages for viewing firewall rules across all namespaces in the instance.
Why
Feature #9 from shellhub-io/team#93 — admins need visibility into firewall rules without navigating into each namespace individually.
Changes
useAdminFirewallRules(paginated list) anduseAdminFirewallRule(single by ID), following the same pattern asuseAdminDeviceshostnameandtagsfields on the filter object. The old"tags" in rule.filtercheck was always true, causing hostname-filtered rules to display as "All devices". Now checkstags.length > 0before using the tags branchClipboardDocumentListIcontoCpuChipIconfor hostname filters — clearer association with devicesTesting
59 new tests across three files covering hook behavior, list page states, client-side search filtering, detail page rendering, and filter badge variants.