Draft
Conversation
Adds solanaSignMessage method to hdwallet-core and implements it in hdwallet-native to support signing raw Solana message bytes. This enables protocols like Bebop that require signing transaction messages for submission to their API (gasless mode). Implementation: - hdwallet-core: Add SolanaSignMessage interface and optional method - hdwallet-native: Implement using adapter's signMessage method - Returns base64-encoded signature Native wallet only for now, other wallets can be added later.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Add signMessage method to PhantomSolanaProvider type - Implement solanaSignMessage using Phantom's Ed25519 signing - Returns signature as base64 string (following native wallet pattern) - Enables Bebop gasless Solana swaps with message signing
- Add solanaSignRawTransaction to SolanaWallet interface - Implement in Phantom using provider.signTransaction - Implement in Native using adapter.signTransaction - Returns signature as base64 string - Enables signing prebuilt Bebop transactions
- Native: use adapter.signMessage(messageBytes) - exact equivalent of signBytes - Phantom: add logging to verify message integrity - Both extract tx.messageBytes and sign without modifying transaction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allowing arbitrary Solana signing for e.g but not limited to, Bebop gasless solana swaps