Added SmallVec::push_mut andSmallVec::insert_mut#406
Open
mematthias wants to merge 3 commits intoservo:v2from
Open
Added SmallVec::push_mut andSmallVec::insert_mut#406mematthias wants to merge 3 commits intoservo:v2from
mematthias wants to merge 3 commits intoservo:v2from
Conversation
- applied cargo fmt
emilio
reviewed
Mar 29, 2026
Member
emilio
left a comment
emilio
left a comment
There was a problem hiding this comment.
Would be nice to split the formatting into a separate (preliminary?) PR.
src/lib.rs
Outdated
| unsafe { ptr.write(value) }; | ||
| unsafe { self.set_len(len + 1) } | ||
|
|
||
| let result = unsafe { ptr.as_mut() }; |
Member
There was a problem hiding this comment.
Maybe just &mut *ptr? Or why would as_mut().unwrap_unchecked() be preferred?
Author
There was a problem hiding this comment.
That is just my writing style; it makes it easier to search.
I simplified it anyway
Reverted cargo fmt changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
push_mutfeature (rust-lang/rust#135974) has already been merged and is expected to be included in the Rust 1.95 stable release. For this reason, we should also addpush_mutandinsert_muthere.Additionally,
cargo fmtwas run.