Skip to content

Conversation

@pdrobnjak
Copy link
Contributor

Summary

  • When ExecuteTransaction() failed (e.g., intrinsic gas errors), Giga returned early without calling Finalize(), so fee deductions from BuyGas() were never committed and the nonce was never incremented
  • This diverged from V2 which always persists fees and nonce via ante handlers, even when execution fails
  • Fix: on execution failure, increment the nonce and call Finalize() to commit state changes, matching V2 behavior

Test plan

  • Run Giga state tests for stEIP1559 category to verify balance mismatches are resolved
  • Verify failed transactions correctly deduct fees and increment nonce in both V2 and Giga modes
  • Run existing unit tests to confirm no regressions

🤖 Generated with Claude Code

When ExecuteTransaction() failed (e.g., intrinsic gas errors), Giga returned
early without calling Finalize(), so fee deductions from BuyGas() were never
committed and the nonce was never incremented. This diverged from V2 which
always persists fees and nonce via ante handlers.

Fix: On execution failure, increment the nonce and call Finalize() to commit
state changes, matching V2 behavior.

Cherry-picked from pd/giga-state-tests-iteration6 (1734418).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link

github-actions bot commented Feb 10, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedFeb 10, 2026, 3:19 PM

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.77%. Comparing base (28bc1c0) to head (09e331e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/app.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2829      +/-   ##
==========================================
- Coverage   56.77%   56.77%   -0.01%     
==========================================
  Files        2070     2070              
  Lines      168274   168283       +9     
==========================================
  Hits        95542    95542              
- Misses      64247    64257      +10     
+ Partials     8485     8484       -1     
Flag Coverage Δ
sei-chain 40.84% <0.00%> (-0.02%) ⬇️
sei-cosmos 48.13% <ø> (+<0.01%) ⬆️
sei-db 68.72% <ø> (ø)
sei-tendermint 58.76% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/app.go 65.76% <0.00%> (-0.10%) ⬇️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant