fix: add optional prop "name" to RadioGroupOwnProps in index.d.ts#1666
Open
jfelege wants to merge 2 commits intosegmentio:masterfrom
Open
fix: add optional prop "name" to RadioGroupOwnProps in index.d.ts#1666jfelege wants to merge 2 commits intosegmentio:masterfrom
jfelege wants to merge 2 commits intosegmentio:masterfrom
Conversation
✅ Deploy Preview for evergreen-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
While attempting to set
nameprop on the ; encountered a typing issue wherenamewas not defined, however, based on the public docs/propTypes it should be allowed.The type definition changes might have been introduced with #1344.
Screenshots (if applicable)
Documentation