fix: remove outdated username placeholder text in login page

[unclamped]

Description

This commit removes an outdated username placeholder text for the login page. This is a reminiscent of an old migration from other media servers.
This commit also changes the data-form-type to just email instead of username. This may break some compatibility with existing password manager saves, but in my testing with Bitwarden that didn't happen (source of the claim of compatibility is GitHub Copilot)

How Has This Been Tested?

Compiled and ran through Docker compose on my local machine, an EndeavourOS host in x86_64.

Screenshots / Logs (if applicable)

New:

Old:

Checklist:

• I have read and followed the contribution guidelines.
• Disclosed any use of AI (see our policy)
• [?] I have updated the documentation accordingly.
• [?] All new and existing tests passed.
• Successful build pnpm build
• [?] Translation keys pnpm i18n:extract
• Database migration (if required)

Summary by CodeRabbit

• Improvements
  • Email input placeholder simplified to display "Email" only.
  • Login now accepts email addresses exclusively; username entry/label has been removed.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

---

📝 Walkthrough

Walkthrough

The PR removes the username public message key from defineMessages in LocalLogin.tsx, updates the email input placeholder to only show email, and changes the email input's data-form-type from "username,email" to "email".

Changes

Cohort / File(s)	Summary
Login messages & inputs src/components/Login/LocalLogin.tsx	Removed username key from defineMessages; changed email input placeholder to email-only; updated email input data-form-type from "username,email" to "email".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰
I hopped through code with carrot cheer,
Tucked “username” gently out of here.
Email now stands pure and bright,
A smaller form to feel just right. 🥕

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removing an outdated username placeholder from the login page, which aligns with the code changes removing the 'username' key from defineMessages and updating input attributes.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/components/Login/LocalLogin.tsx (1)

13-23: ⚠️ Potential issue | 🔴 Critical

Restore messages.password to avoid a formatMessage crash.

intl.formatMessage(messages.password) is used in the password field placeholder at line 107, but the password key is missing from the defineMessages object. This leaves messages.password undefined and will throw at render time, breaking the login form.

✅ Suggested fix

 const messages = defineMessages('components.Login', {
   loginwithapp: 'Login with {appName}',
   username: 'Username',
   email: 'Email Address',
+  password: 'Password',
   validationemailrequired: 'You must provide a valid email address',
   validationpasswordrequired: 'You must provide a password',
   loginerror: 'Something went wrong while trying to sign in.',
   signingin: 'Signing In…',
   signin: 'Sign In',
   forgotpassword: 'Forgot Password?',
 });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/components/Login/LocalLogin.tsx` around lines 13 - 23, The defineMessages
object 'messages' in LocalLogin.tsx is missing the 'password' key which causes
intl.formatMessage(messages.password) used in the password field placeholder to
crash; add a 'password' entry to the defineMessages call (alongside
loginwithapp, username, email, etc.) with an appropriate string (e.g.,
'Password') so that messages.password is defined, then ensure any tests or
usages of intl.formatMessage refer to messages.password consistently.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@src/components/Login/LocalLogin.tsx`:
- Around line 13-23: The defineMessages object 'messages' in LocalLogin.tsx is
missing the 'password' key which causes intl.formatMessage(messages.password)
used in the password field placeholder to crash; add a 'password' entry to the
defineMessages call (alongside loginwithapp, username, email, etc.) with an
appropriate string (e.g., 'Password') so that messages.password is defined, then
ensure any tests or usages of intl.formatMessage refer to messages.password
consistently.

[unclamped]

oh god, I didn't actually try logging in. my bad, wrong delete

[0xSysR3ll]

You should run pnpm format before committing or CI will fail :)

[fallenbagel]

This will break for jellyfin/emby users still. Normal imported users get their usernames set as their email as they do not have emails associated with their accounts. So unfortunately we cant restrict the form type.

We can remove the placeholder so its not confusing but we will need to keep this removed. And maybe add a tool tip to the field with a short way of explaining the above ^

Maybe like "if you haven't sent an email.." etc

[unclamped]

@fallenbagel Do you know of any tooltips I can use as reference in Seerr? This exceeds my knowledge

[unclamped]

sorry I completely forgot about this PR. I'm doing the changes in a few days if that's not an issue, I'm busy with exams