Skip to content

feat(build): replace unwraps by expects with useful messages in build.rs #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaoleal wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(build): replace unwraps by expects with useful messages in build.rs #136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions libbitcoinkernel-sys/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ fn main() {
.arg("-DENABLE_IPC=OFF")
.arg(format!("-DCMAKE_INSTALL_PREFIX={}", install_dir.display()))
.status()
.unwrap();
.expect("cmake should be installed and available in PATH.");

let num_jobs = env::var("NUM_JOBS")
.ok()
Expand All @@ -56,15 +56,15 @@ fn main() {
.arg(build_config)
.arg(format!("--parallel={num_jobs}"))
.status()
.unwrap();
.expect("cmake build should succeed after configure");

Command::new("cmake")
.arg("--install")
.arg(&build_dir)
.arg("--config")
.arg(build_config)
.status()
.unwrap();
.expect("cmake install should succeed after build");

// Check if the build system used a multi-config generator
let lib_dir = if install_dir.join("lib").join(build_config).exists() {
Expand Down
Loading