fix: change contracts from json to yaml#56
Conversation
Thank you for the pull request! 💙The Scribe-Server team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
|
Hi @andrewtavis, this is a PR to adapt Scribe-Server to new contracts change |
andrewtavis
left a comment
There was a problem hiding this comment.
praise: Thanks so much for the quick work here, @DeleMike! So great to be able to move on to the new contracts so quickly! 🚀
|
note: I added a |
Contributor checklist
./pre-commitexecutable as well asmake lintand have fixed all reported issuesDescription
As discussed in the call, we are moving away from
.JSONfiles for contracts to.yamlfiles. This PR adapts the Server to follow the new contract rules.In this PR, I copied the yaml files from the Liveshare(Android Repo) into the Server directory.
Then I tested the process and the server outputs it well.
Example:
GET http://localhost:8080/api/v1/contractsResponse:
GET http://localhost:8080/api/v1/contracts?lang=enResponse:
Related issue