Skip to content

feat: expand generated emoji keywords from 3 to 9#671

Merged
andrewtavis merged 1 commit intoscribe-org:mainfrom
aicontentcreate2023-star:expand-emoji-keywords-to-nine
Mar 5, 2026
Merged

feat: expand generated emoji keywords from 3 to 9#671
andrewtavis merged 1 commit intoscribe-org:mainfrom
aicontentcreate2023-star:expand-emoji-keywords-to-nine

Conversation

@aicontentcreate2023-star
Copy link
Contributor

Fixes #670

Summary

Increase the maximum number of emoji suggestions per keyword from 3 to 9 to support the upcoming emoji autosuggest feature in Scribe client apps.

Changes

src/scribe_data/unicode/generate_emoji_keywords.py

  • Updated EMOJI_KEYWORDS_DICT constant from 3 to 9
  • This constant controls the emojis_per_keyword parameter passed to gen_emoji_lexicon()

tests/unicode/test_generate_emoji_keywords.py

  • Updated test assertion to expect emojis_per_keyword=9 instead of 3
  • Ensures test coverage matches the new behavior

Impact

  • Emoji keyword generation will now produce up to 9 emoji suggestions per word instead of 3
  • Enables richer emoji suggestions via the `: autosuggest functionality in Scribe client applications
  • No breaking changes — existing clients will simply receive more emoji options

Testing

# Run the updated test
pytest tests/unicode/test_generate_emoji_keywords.py -v

The change is minimal and low-risk — a single constant update with corresponding test coverage.

Fixes scribe-org#670

Summary:
Increase the maximum number of emoji suggestions per keyword from 3 to 9
to support the upcoming emoji autosuggest feature in Scribe client apps.

Changes:
- src/scribe_data/unicode/generate_emoji_keywords.py:
  Updated EMOJI_KEYWORDS_DICT constant from 3 to 9
- tests/unicode/test_generate_emoji_keywords.py:
  Updated test assertion to expect emojis_per_keyword=9

Impact:
- Emoji keyword generation will now produce up to 9 emoji suggestions
  per word instead of 3
- Enables richer emoji suggestions via the : autosuggest functionality
  in Scribe client applications
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

Thank you for the pull request! 💙

The Scribe-Data team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Data rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the pytest, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR Commit Check

  • The commit messages for the remote branch of a new contributor should be checked to make sure their email is set up correctly so that they receive credit for their contribution
    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo (can be set with git config --global user.email "GITHUB_EMAIL")

@andrewtavis
Copy link
Member

note, @aicontentcreate2023-star: It looks like your email for GitHub isn't set up properly. See the message here for how to fix this for future commits :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great first commit, @aicontentcreate2023-star!

@andrewtavis andrewtavis merged commit 744ddd4 into scribe-org:main Mar 5, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand generated emojis to a maximum of nine

2 participants